Conversation
jmhooper
approved these changes
Jul 16, 2020
Contributor
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
This is cool, thanks for putting this together
**Why**: While Airbnb's JavaScript standards do reference this rule in context of 10.8 multiline import, the rule as configured applies to much more than just import statements, and often conflicts with Prettier formatting
Why: The single page document authorization upload flow will be implemented using React. As part of this effort, it will be necessary to integrate Acuant's Web SDK for image capturing.
This was referenced Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The single page document authorization upload flow will be implemented using React. As part of this effort, it will be necessary to integrate Acuant's Web SDK for image capturing.
This pull request proposes a minimal set of changes for a basic integration of Acuant image capture using React components.
As implemented, it's largely composed of:
It does not intend to:
Localize texts (see LG-3175: Create localization utilities for React components #3909)Edit: Since LG-3175: Create localization utilities for React components #3909 is merged, this is now partly implemented here for strings which exist and are likely to remain unchanged (see 7c29c2fa599ddbf74be8035e289a46c2ceff7e4f).Testing steps:
Screenshot: